Can't compile git sources - 'skb' undeclared

Live forum: http://rt2x00.serialmonkey.com/viewtopic.php?t=4780

Fjodor

08-05-2008 09:18:20

I get the following when trying to compile the git sources

net/mac80211/tx.c In function ‘ieee80211_tx_h_check_assoc’
net/mac80211/tx.c229 error ‘skb’ undeclared (first use in this function)
net/mac80211/tx.c229 error (Each undeclared identifier is reported only once
net/mac80211/tx.c229 error for each function it appears in.)
make[3] *** [net/mac80211/tx.o] Error 1
make[2] *** [net/mac80211] Error 2
make[2] *** Waiting for unfinished jobs....

ieee80211_tx_h_check_assoc begins like this

static ieee80211_tx_result
ieee80211_tx_h_check_assoc(struct ieee80211_tx_data *tx)
{
#ifdef CONFIG_MAC80211_VERBOSE_DEBUG
struct sk_buff *skb = tx->skb;
struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data;
#endif /* CONFIG_MAC80211_VERBOSE_DEBUG*/
struct ieee80211_tx_info *info = (void *)skb->cb;
u32 sta_flags;

Only declaring skb and hdr if we have selected MAC80211_VERBOSE_DEBUG and then going on to operate on those variables seems like a Really Bad Idea(tm) to me, however since I might have to use the debugging option in the other thread, I'll happily enable it.

For those not interested in debugging, though, my take is still that this is a RBI...

Best regards,

F

IvD

08-05-2008 12:56:21

Thanks for the report, I have fixed this in rt2x00.git and have forwarded the patch to upstream.

Fjodor

08-05-2008 14:23:03

No prob ;-)

/F