rt2x00.serialmonkey.com

I guess in a perfect world, pre-up would be better because it would ensure that all related configuration items are set before driver operations begin. e.g. the driver would not try to do a scan just before the operating mode was switched to monitor.

However, the driver isn't set up to be able to do that, which - I suspect - is why you needed the ifconfig command: it was effectively bringing the driver up before the following pre-ups were done.

So, in practical terms, using "up" commands simpifies things in the configuration script.

Hi daniel_matthes,

Me again. I have a patch that's intended to resolve the "SIOCIFFLAGS: invalid argument" problem with 2.6.24 kernels. It appears to work in my environment, but that is very restricted. Could you try it?

If it works for you, you may also find that you can now do pre-up commands without having to first do "ifconfig wlan up".

The file is attached as preup1.patch.gz.

Thanks, in advance,

Hi Vern,

I've tested the driver rt73-cvs-2008022102 patched with preup1.patch. It doesn't work correctly.

After bringing up the device and running "iwconfig", I got the following output.



when i bring up the device after a bring down, I got the following error message



/var/log/messages is attached

regards Daniel

Hi Daniel,

Jeez, you'd think I could have thought to do at least that much myself!

Veddy embarrassing - and thanks.

Vern, is the (corrected) patch already checked in ?

Best,

Reinhard

No.

I've modified the "preup1" patch enough that the driver will cycle through ups and downs without complaint - but it still doesn't work right. For example, after ifdown, then ifup, a scan operation does not return results.

So what I'd like to do is get that item resolved, then - if Daniel or you have the time and inclination - let him, or you, take another pass at it.

daniel_matthes:

Did "preup1" at least allow you to do preups without having to do ifconfig up?

Thanks again for your work,

Not realy. After reboot it seems to work. But after "ifdown/ifup" the same error occures.

Hi Daniel,

I've attached a modified version of the patch - preup2.patch.gz - that seems to work for me cycling through ifup -> ifdown -> ifup, etc. The main change is that it initializes the ASIC on every open.

It should also still allow you to do preup configuration without having to do an ifconfig first.

Could you try it and post your results here?

Thanks,

Hi Daniel,

I've discovered problems with preup2. I've posted a later version - preup3 - on "SIOSSIFFLAGS: Invalid argument" on ifconfig up on that should fix things. It would be very helpful to also see that there are no problems with it in an ARM environment, so would it be possible for you to try that version of the patch and report your results before getting it put into CVS?

Thanks,

Hi Vern,

Sorry, but I can not test the patches before friday. Our team is from Today till Thursday on Nuremberg on the Embedded World exhibition. And they took along the WLAN USB stick.

Regards Daniel

Hi Daniel,

That's fine. Thanks again for your work. When and if you get a chance, making sure ARM operations are OK would be good.

Thanks,

Hi Vern,

Now I'm back from my winter holidays. Today I've tested a vanilla copy of rt73-cvs-2008031007.

I've tested the driver in two ways. At first by using 'ups' and further by using 'pre-ups' without entering 'pre-up ifconfig wlan0 up'.

Every time it's possible to bring up the device without errors. But after bringing up there are some problems.

When I bring up the device by using 'ups', after reboot its possible to ping the ap. When I bring down the wlan adapter and bring up the device again, after that it's not possible to ping the ap. By using 'pre-ups' it is also not possible to ping the ap after reboot.

--> so I've attached some /var/log/messages files

regards daniel

Hi daniel,

I can't reproduce the problem. I can pretty much do ifup, ifdown, ifup, ... ad infinitem, and I see in my log that the open function is called each time ifup is done, and the close function is called each time ifdown is done.

In both your logs I only see the open function called once, and the close function called once - which would imply that ifup (or ifconfig <iface> up) is only done once, and ifdown (or ifconfig <iface> down) are also only done once.

So I'm a little puzzled, here. Can you provide some detail on your procedures?

Thanks,

Hi Vern,

I've done a new test run. I've tested two different driver versions. At first I've tested a vanilla copy of rt73-cvs-2008022102 and then a copy of rt73-cvs-2008031007.

This is my test procedure:

0. /etc/network/interfaces is configured with 'ups'

1. reboot the system
2. /etc/init.d/rcS executes modprobe rt73
3. /etc/init.d/rcS executes ifup wlan0
4. ping <ap address>
5. ifdown -v wlan0
6. ifup -v wlan0
7. ping <ap address>
8. ifdown -v wlan0

By using the driver version 031007 step 7 does'nt work.

Further the step 6 output of driver version 022102 and version 031007 is different.

version 022102 output:



version 0031007 output:



I've attached the log output.

Regards Daniel

Hi Daniel,

Nice catch. Thanks for the extra legwork. It turns out that parts of the chip setup are lost during close processing. As a result, there's some chip initialization that needs to be done when the device is re-opened.

The attached patch -reopen1.patch.gtz - fixes the re-open issues I've been able to identify in my own environment. Could you apply it to a vanilla copy of the latest CVS and see if it's OK in yours?

Thanks again for your efforts,