[rt2x00-users] [PATCH v3 0/4] Further L2 padding fixes.
Ivo van Doorn
ivdoorn at gmail.com
Thu Dec 3 18:36:12 UTC 2009
> > * L2PAD is only present for data frame and an easy way to check for that is
> > * to compare header_length with 24 bytes.
> > */
> > #define L2PAD_SIZE(__header) \
> > ((__header)<24 ? 0 : ((4 - ((__header)%4))%4))
> That depends on what the purpose of the L2PAD_SIZE macro is going to
> be. At the moment
> the intention is to have L2PAD_SIZE compute the number of l2pad bytes
> necessary, if a
> payload is present. Detection on whether actually a payload is present
> and whether the
> outcome of this macro should be used should be at the call-sites of this macro.
I personally prefer the current version, I don't see a valid reason for
L2PAD_SIZE to depend on the header size. The caller should check if
the payload is present and L2 padding is required.
More information about the users