[rt2x00-users] [PATCH] rt2x00 : Fix for the index hack in txdone

Alban Browaeys prahal at yahoo.com
Tue Jul 14 08:07:28 EST 2009


Fix one every 24 entries processed error. Still there are lot of other missed entries that makes
no sense to me yet (only happens for big skb->len though any of the big ones goes through without issue : 367, 423 does not pass while 432 does ... could be a padding/round issue even though I tried a few roundup(skb->len,4) , roundup(skb->len+4,4) trying to reproduce what is in rt2800usb got get_tx_len ... though I have not found the correct register to apply this to - and how to have this padding added while the dma memory allocated is fixed for the pci driver).

For the previous patch I did not managed to inline it properly via  :
git format-patch --signoff --stdout --inline origin | git imap-send
Don't know why it ended up attached. This one too so I copy n'pasted in the email. Hope it does not end up flowed or wrapped even though
I followed the howto to prevent that.
Sorry.

Alban

--------------------------------------------------------

When index is 0 - 1 it is queue limit.

Signed-off-by: Alban Browaeys <prahal at yahoo.com>
---
 drivers/net/wireless/rt2x00/rt2800pci.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c b/drivers/net/wireless/rt2x00/rt2800pci.c
index 1ad7ea2..38b719c 100644
--- a/drivers/net/wireless/rt2x00/rt2800pci.c
+++ b/drivers/net/wireless/rt2x00/rt2800pci.c
@@ -2501,6 +2501,7 @@ static void rt2800pci_txdone(struct rt2x00_dev *rt2x00dev)
 		entry = &queue->entries[index];
 */
 		index = queue->index[Q_INDEX];
+		if(index == 0) index = queue->limit;
 		entry = &queue->entries[index - 1];
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix-for-the-index-hack-in-txdone.patch
Type: text/x-patch
Size: 455 bytes
Desc: not available
URL: <http://rt2x00.serialmonkey.com/pipermail/users_rt2x00.serialmonkey.com/attachments/20090714/be797fe2/attachment-0001.bin>


More information about the users mailing list