[rt2x00-users] [PATCH 4/5] rt2x00: Update rt2800 HT capabilities

[Helmut Schaa]

Am Monday 23 August 2010 schrieb Ivo Van Doorn:
> On Mon, Aug 23, 2010 at 2:54 PM, Helmut Schaa
> <helmut.schaa at googlemail.com> wrote:
> > Am Monday 23 August 2010 schrieb Ivo van Doorn:
> >> The legacy Ralink drivers have some mac80211 code enabled,
> >> and enable flags IEEE80211_HT_CAP_SM_PS and
> >> IEEE80211_HT_CAP_DSSSCCK40. So apparently these features
> >> are supported and we can enable them as well.
> >>
> >> Signed-off-by: Ivo van Doorn <IvDoorn at gmail.com>
> >> ---
> >>  drivers/net/wireless/rt2x00/rt2800lib.c |    4 +++-
> >>  1 files changed, 3 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> >> index ecbd07a..14549f5 100644
> >> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> >> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> >> @@ -3053,9 +3053,11 @@ int rt2800_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
> >>
> >>       spec->ht.cap =
> >>           IEEE80211_HT_CAP_SUP_WIDTH_20_40 |
> >> +         IEEE80211_HT_CAP_SM_PS |
> >
> > We need to handle IEEE80211_CONF_CHANGE_SMPS in the config callback to really
> > make use of this flag. Not sure if it breaks anything when we enable this flag
> > but don't handle SMPS changes in the config callback.
> 
> No we don't, legacy driver only handles the value for the TXWI, which is handled
> by patch 5/5.

Yeah, but the TXWI flag should correspond with the SMPS mode the remote
station is using. Not the SMPS mode we are using. See other mail as well ;)

> >>           IEEE80211_HT_CAP_GRN_FLD |
> >>           IEEE80211_HT_CAP_SGI_20 |
> >> -         IEEE80211_HT_CAP_SGI_40;
> >> +         IEEE80211_HT_CAP_SGI_40 |
> >> +         IEEE80211_HT_CAP_DSSSCCK40;
> >
> > Do all rt2800 devices support this?
> 
> Don't know, Legacy driver sets it unconditionally for HT devices.

Ok, should be fine I guess. This flag only tells the remote peer only
that we support DSSSCCK40.

Helmut