[rt2x00-users] [PATCH 7/7] rt2x00: Fix WMM Queue naming
helmut.schaa at googlemail.com
Wed Dec 8 02:25:42 EST 2010
Am Dienstag, 7. Dezember 2010 schrieb Johannes Stezenbach:
> On Tue, Nov 30, 2010 at 05:48:48PM +0100, Helmut Schaa wrote:
> > Am Sonntag 28 November 2010 schrieb Ivo van Doorn:
> > > The Queue names were incorrectly copied from the legacy drivers,
> > > as a result the queue names were inversed to what was expected.
> > This comment is a bit misleading. The values were correctly copied
> > from the legacy drivers but mac80211 uses a different mapping and since
> > we just use mac80211 queue id's our queue names don't match their
> > purpose.
> > legacy drivers:
> > QID_AC_BE 0
> > QID_AC_BK 1
> > QID_AC_VI 2
> > QID_AC_VO 3
> > mac80211:
> > QID_AC_BE 3
> > QID_AC_BK 2
> > QID_AC_VI 1
> > QID_AC_VO 0
> > Otherwise fine with me ...
> It seems the patch which ended up in git has
> QID_AC_BK and QID_AC_BE swapped compared to mac80211.
> IEEE80211_AC_BE = 2, while QID_AC_BE = 3.
You're right, good catch!
> BTW, what is QID_MGMT? There is only one usage in rt2800pci.c,
> this does not look right.
It's just another tx queue (used by the legacy drivers for mgmt frames) that
we dont use at all (yet). The specs say it is a "priority" queue whatever
that means ;)
More information about the users