[rt2x00-users] [PATCH 7/7] rt2x00: Fix WMM Queue naming

Johannes Stezenbach js at sig21.net
Wed Dec 8 03:14:06 EST 2010


Hi,

On Tue, Dec 07, 2010 at 04:54:23PM +0100, Ivo Van Doorn wrote:
> >> IEEE80211_AC_BE = 2, while QID_AC_BE = 3.
> >
> > You're right, good catch!
> 
> Thanks, the Legacy driver had mixed up those as well (comments
> and usage were different). So I seem to have fixed it up the wrong way.
> I'll update the patch.

Thanks, I'm sorry I didn't notice earlier but it takes eagle eyes to spot...

> >> BTW, what is QID_MGMT?  There is only one usage in rt2800pci.c,
> >> this does not look right.
> >
> > It's just another tx queue (used by the legacy drivers for mgmt frames) that
> > we dont use at all (yet). The specs say it is a "priority" queue whatever
> > that means ;)
> 
> QID_MGMT is actually only for management frames, in rt2400pci and rt2500pci
> it was called the PRIO queue. The legacy driver used it to enqueue management
> frames. But mac80211 demands that those frames are send over the normal
> queues, so we don't need the MGMT queue. For rt2400pci and rt2500pci this
> means that they have 2 queues, to allow some sort of prioritization to occur on
> the queues. But for all WMM capable devices, this is not possible since mac80211
> has limited the number of TX queues to 4 (while rt2x00 could support up to 5).

Thanks for the info.

Johannes



More information about the users mailing list