[rt2x00-users] [PATCH] rt2x00: Fix firmware loading regression on x86_64.

[Johannes Stezenbach]

On Thu, Dec 09, 2010 at 12:31:15PM +0100, Wolfgang Kufner wrote:
> +#ifdef CONFIG_X86_64
> +	__inline_memcpy(rt2x00dev->csr.base + offset, value, length);
> +#else
>  	memcpy_toio(rt2x00dev->csr.base + offset, value, length);
> +#endif

Polluting drivers with arch specific code is wrong.

The questions is, is memcpy_toio() broken or does
the driver use it incorrectly?  See e.g.
http://kerneltrap.org/mailarchive/linux-kernel/2010/8/2/4601510/thread#mid-4601510


HTH
Johannes