[rt2x00-users] [PATCH] rt2x00: Fix firmware loading regression on x86_64.
Ivo Van Doorn
ivdoorn at gmail.com
Fri Dec 10 00:48:40 EST 2010
On Thu, Dec 9, 2010 at 1:19 PM, Johannes Stezenbach <js at sig21.net> wrote:
> On Thu, Dec 09, 2010 at 12:31:15PM +0100, Wolfgang Kufner wrote:
>> +#ifdef CONFIG_X86_64
>> + __inline_memcpy(rt2x00dev->csr.base + offset, value, length);
>> memcpy_toio(rt2x00dev->csr.base + offset, value, length);
> Polluting drivers with arch specific code is wrong.
> The questions is, is memcpy_toio() broken or does
> the driver use it incorrectly? See e.g.
Wolfgang, If I recall correctly, you were going to test if using
__iowrite32_copy() would work right? Because then it would be
usuable without the #ifdef statement.
More information about the users