[rt2x00-users] [PATCH] rt2x00: Fix and fine-tune rf registers for RT3070/RT3071/RT3090

[RA-Jay Hung]

> >                 rt2800_register_read(rt2x00dev, LDO_CFG0, &reg);
> >                 rt2x00_set_field32(&reg, LDO_CFG0_BGSEL, 1);
> >                 if (rt2x00_rt_rev_lt(rt2x00dev, RT3071, REV_RT3071E) ||
> >                     rt2x00_rt_rev_lt(rt2x00dev, RT3090, REV_RT3090E)) {
> > +                       rt2x00_set_field32(&reg, LDO_CFG0_BGSEL, 1);
> > +
> >                         rt2x00_eeprom_read(rt2x00dev,
> EEPROM_NIC_CONF1, &eeprom);
> >                         if (rt2x00_get_field16(eeprom,
> EEPROM_NIC_CONF1_DAC_TEST))
> >                                 rt2x00_set_field32(&reg,
> LDO_CFG0_LDO_CORE_VLEVEL, 3);
>
> The setting of LDO_CFG0_BGSEL is already done unconditionally just before the if.
> Why does it need to be done again?

You are right, I will remove this line. Thanks review.

Jay
CONFIDENTIALITY STATEMENT : The information, attachments and any rights attaching in this e-mail are confidential and privileged; it is intended only for the individual or entity named as the recipient hereof.Any disclosure, copying, distribution, dissemination or use of the contents of this e-mail by persons other than the intended recipient is STRICTLY PROHIBITED and may violate applicable laws.If you have received this e-mail in error, please delete the original message and notify us by return email or collect call immediately. Thank you.