[rt2x00-users] [PATCH 2/3] rt2x00: Reorganize RT chipset setting for PCI/SOC devices.

[Gertjan van Wingerde]

On 02/14/10 02:15, Ivo van Doorn wrote:
> Hi,
> 
>> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
>> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
>> @@ -40,6 +40,9 @@
>>  #if defined(CONFIG_RT2X00_LIB_USB) || defined(CONFIG_RT2X00_LIB_USB_MODULE)
>>  #include "rt2x00usb.h"
>>  #endif
>> +#if defined(CONFIG_RT2X00_LIB_PCI) || defined(CONFIG_RT2X00_LIB_PCI_MODULE)
>> +#include "rt2x00pci.h"
>> +#endif
> 
> this is very ugly, but apparently it is unavoidable to make rt2800lib free from
> PCI and USB specific code... :(
> 

Actually, this is a temporary situation, and this chunk can be removed again after
patch 3 of the series has been applied.

I'll create a cleanup patch to exactly to that.

With respect to the USB specific code, I have to look at if there is a way to
resolve that, as the USB specific code is only there in 1 place. Maybe a call-back
function to the bus-specific rt2800 drivers could help here.

---
Gertjan.