[rt2x00-users] [PATCH 2/2] rt2x00 : fix txdone implementation

Pavel Roskin proski at gnu.org
Thu Feb 25 01:58:14 UTC 2010


Quoting Alban Browaeys <prahal at yahoo.com>:

> Properly move to the headroom position in dma mapped skb. The hw extra
> headroom is now taken into account.
>
> Signed-off-by: Alban Browaeys <prahal at yahoo.com>
...
> -	rt2x00_set_field32(&word, TXD_W2_SD_PTR1,
> -			   skbdesc->skb_dma + rt2x00dev->ops->extra_tx_headroom);
> +	rt2x00_set_field32(&word, TXD_W2_SD_PTR1, skbdesc->skb_dma
> +			   + rt2x00dev->ops->extra_tx_headroom);

I think it's just a formatting change.  I would not mix formatting  
changes with the real fixes.  I can understand reformatting code that  
is also modified in some other way, but that's even a separate function.

>  		txwi = (__le32 *)(entry->skb->data -
> -				  rt2x00dev->hw->extra_tx_headroom);
> +				  rt2x00dev->ops->extra_tx_headroom);

Now that's a real change.

-- 
Regards,
Pavel Roskin



More information about the users mailing list