[rt2x00-users] [PATCH 1/2] rt2x00: Use ioremap for SoC devices instead of KSEG1ADDR.

Helmut Schaa helmut.schaa at googlemail.com
Thu Jul 22 00:53:07 AEST 2010


Hi,

Am Dienstag 20 Juli 2010 schrieb Gertjan van Wingerde:
> On 07/20/10 20:53, Ivo Van Doorn wrote:
> > On Sat, Jul 17, 2010 at 5:28 PM, Gertjan van Wingerde
> > <gwingerde at gmail.com> wrote:
> >> Make the code a bit more portable to architectures that do not support
> >> KSEG1ADDR.
> >>
> >> Signed-off-by: Gertjan van Wingerde <gwingerde at gmail.com>

Ok, this patch just works fine on SoC devices.

So, you can add

Tested-by: Helmut Schaa <helmut.schaa at googlemail.com>

to the next submission.

Helmut

> >> ---
> > 
> > Could you check this sparse issue, which is introduced with your patch:
> > 
> > drivers/net/wireless/rt2x00/rt2800pci.c:89:27: warning: cast removes
> > address space of expression
> > drivers/net/wireless/rt2x00/rt2800pci.c:91:42: warning: incorrect type
> > in argument 2 (different address spaces)
> > drivers/net/wireless/rt2x00/rt2800pci.c:91:42:    expected void const
> > volatile [noderef] <asn:2>*src
> > drivers/net/wireless/rt2x00/rt2800pci.c:91:42:    got unsigned int
> > [usertype] *base_addr
> > 
> 
> The attached should do the trick.
> 
> Again, I will formally re-submit both patches once Helmut has had the chance to test
> whether it works correctly.
> 
> ---
> Gertjan
> 





More information about the users mailing list