[rt2x00-users] [PATCH] rt2x00: Remove suspicious register write

[Gertjan van Wingerde]

On 06/02/10 08:19, Helmut Schaa wrote:
> Remove suspicious register write as the reg variable is never filled
> with an TX_SW_CFG2 associated value before.
> 
> Signed-off-by: Helmut Schaa <helmut.schaa at googlemail.com>
> ---
> 
> Gertjan, could you please double check if there was a valid reason
> for that write? My guess is that we are writing wrong values there.
> Thanks.
> 

Good catch. This seems to be a left-over of a previous version of the patch that snuck in.

Acked-by: Gertjan van Wingerde <gwingerde at gmail.com>


> Ivo, sending directly to you for merging ;)

I guess the approach should be to send to rt2x00 users mailing list copying in Ivo, yourself,
and myself.

> 
>  drivers/net/wireless/rt2x00/rt2800lib.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index db4250d..9937526 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -1328,7 +1328,6 @@ int rt2800_init_registers(struct rt2x00_dev *rt2x00dev)
>  		} else {
>  			rt2800_register_write(rt2x00dev, TX_SW_CFG2, 0x00000000);
>  		}
> -		rt2800_register_write(rt2x00dev, TX_SW_CFG2, reg);
>  	} else if (rt2x00_rt(rt2x00dev, RT3070)) {
>  		rt2800_register_write(rt2x00dev, TX_SW_CFG0, 0x00000400);
>