[rt2x00-users] [RFC] rt2x00: Fix TX_STA_FIFO handling

Helmut Schaa helmut.schaa at googlemail.com
Thu Jun 10 21:25:57 UTC 2010


Am Donnerstag 10 Juni 2010 schrieb Gertjan van Wingerde:
> On 06/08/10 15:28, Helmut Schaa wrote:
> > Currently rt2800pci will read TX_STA_FIFO until the previously read value
> > matches the current value. However, it is obvious that TX_STA_FIFO only
> > contains values that can easily be the same for multiple consecutive frames
> > (especially when communicating with only one other STA). Hence, we often
> > ended up with reading only the first entry and ignoring the rest.
> > 
> > One result was that when the TX_STA_FIFO contained multiple entires, only
> > the first one was read and properly handled while the others remained in the
> > tx queue.
> > 
> > Thus, drop this check but introduce a maximum number of reads. All legacy
> > drivers use the size of the tx ring as limit but state that the TX_STA_FIFO
> > has only 16 entries. So, let's just stick with the tx ring size for now.
> > 
> > Signed-off-by: Helmut Schaa <helmut.schaa at googlemail.com>
> 
> Seems to be OK and aligned with the Ralink driver.
> 
> Acked-by: Gertjan van Wingerde <gwingerde at gmail.com>

Thanks.



More information about the users mailing list