[rt2x00-users] [PATCH] rt2x00: Fix typo in rt2800_config_txpower

Helmut Schaa helmut.schaa at googlemail.com
Fri Jun 11 12:07:31 UTC 2010


Am Freitag 11 Juni 2010 schrieb Gertjan van Wingerde:
> On 06/11/10 13:10, Helmut Schaa wrote:
> > Fix a typo in rt2800_config_txpower which may cause random data to be
> > written to BBP register 1.
> > 
> > Signed-off-by: Helmut Schaa <helmut.schaa at googlemail.com>
> 
> Actually BPP register 1 wouldn't change value at all, and it is TX_PWR_CFG_0 that would
> get a strange value. But, yes, good catch.

Ehhm, yes, right. I'll resend with a better commit message. 

> Acked-by: Gertjan van Wingerde <gwingerde at gmail.com>
> 
> > ---
> >  drivers/net/wireless/rt2x00/rt2800lib.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> > index 9754bc9..cb2c01d 100644
> > --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> > +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> > @@ -1079,7 +1079,7 @@ static void rt2800_config_txpower(struct rt2x00_dev *rt2x00dev,
> >  	u8 r1;
> >  
> >  	rt2800_bbp_read(rt2x00dev, 1, &r1);
> > -	rt2x00_set_field8(&reg, BBP1_TX_POWER, 0);
> > +	rt2x00_set_field8(&r1, BBP1_TX_POWER, 0);
> >  	rt2800_bbp_write(rt2x00dev, 1, r1);
> >  
> >  	rt2800_register_read(rt2x00dev, TX_PWR_CFG_0, &reg);
> 
> 




More information about the users mailing list