[rt2x00-users] [PATCH] rt2x00: Disable link tuning in AP mode

[Gertjan van Wingerde]

On 06/21/10 10:00, Helmut Schaa wrote:
> Since the link tuning is based on average RSSI values taken from all received
> frames it doesn't make sense to enable it in AP mode where every associated
> station provides independent RSSI values. Furthermore the legacy drivers
> don't enable link tuning in AP mode as well.
> 
> Signed-off-by: Helmut Schaa <helmut.schaa at googlemail.com>

Seems like a sane thing to do, as an AP has many links to monitor, not just one,
like an STA.

Acked-by: Gertjan van Wingerde <gwingerde at gmail.com>

> ---
> 
> Doesn't seem to have much impact during my tests. Nevertheless, disabling
> link tuning in AP mode seems correct to me. Did I miss anything? Any
> objections?
> 
> Thanks,
> Helmut
> 
>  drivers/net/wireless/rt2x00/rt2x00link.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/rt2x00link.c b/drivers/net/wireless/rt2x00/rt2x00link.c
> index 0efbf5a..2f8136c 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00link.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00link.c
> @@ -271,11 +271,11 @@ void rt2x00link_start_tuner(struct rt2x00_dev *rt2x00dev)
>  
>  	/*
>  	 * Link tuning should only be performed when
> -	 * an active sta or master interface exists.
> -	 * Single monitor mode interfaces should never have
> -	 * work with link tuners.
> +	 * an active sta interface exists. AP interfaces
> +	 * don't need link tuning and monitor mode interfaces
> +	 * should never have to work with link tuners.
>  	 */
> -	if (!rt2x00dev->intf_ap_count && !rt2x00dev->intf_sta_count)
> +	if (!rt2x00dev->intf_sta_count)
>  		return;
>  
>  	rt2x00link_reset_tuner(rt2x00dev, false);