[rt2x00-users] [PATCH] rt2x00: Add 5GHz support for RF3052 devices

Ivo Van Doorn ivdoorn at gmail.com
Thu May 6 22:06:38 AEST 2010


John,

Please drop this patch. I just talked with Gertjan and I will be
sending an updated patch in a few minutes.

Ivo

On Thu, May 6, 2010 at 1:22 PM, Ivo Van Doorn <ivdoorn at gmail.com> wrote:
> On Thu, May 6, 2010 at 1:12 PM, Gertjan van Wingerde
> <gwingerde at gmail.com> wrote:
>> On Thu, May 6, 2010 at 1:01 PM, Ivo van Doorn <ivdoorn at gmail.com> wrote:
>>> According to the Ralink drivers, the RF3052 chipset
>>> supports the 5GHz band. Update channel initialization
>>> to add the corresponding channels for this chip.
>>>
>>> Signed-off-by: Ivo van Doorn <IvDoorn at gmail.com>
>>
>> Actually, I believe that this is not correct (sorry I don't have the
>> Ralink driver at hand at the moment, nor the rt2x00 tree).
>
> Well the original Ralink driver does state this device is a 5GHz device.
>
>> AFAIK the RF3052 needs the same initialization as for RF3020, RF3021,
>> RF3022, etc extended with the correct values for
>> 5GHz band.
>
> RF3020 and RF3021 are 2.4GHz devices.
>
>> So, NAK for this patch.
>>
>> Also, please keep in mind that for proper RT3572 support more needs to
>> be done, also in the register, BPP, and RFCSR initializations.
>
> It could be that the initialization of RF3052 is incomplete, however that is not
> limited to the 5GHz feature, but for both bands. Note that the
> difference in initialization
> only exists for settings the antenna and channel which already detect
> if the initialization
> should be done on the 2.4 or 5 GHz band.
> So this argument shouldn't block this patch...
>
> Ivo
>




More information about the users mailing list