[rt2x00-users] [PATCH] [BISECTED] rt2x00: Fix load_firmware - PBF system register not ready regression.

Ivo Van Doorn ivdoorn at gmail.com
Mon Nov 22 16:51:27 UTC 2010


Hi,

> diff --git a/drivers/net/wireless/rt2x00/rt2x00pci.h
> b/drivers/net/wireless/rt2x00/rt2x00pci.h
> index b854d62..a8c6cc1 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00pci.h
> +++ b/drivers/net/wireless/rt2x00/rt2x00pci.h
> @@ -64,7 +64,11 @@ static inline void
> rt2x00pci_register_multiwrite(struct rt2x00_dev *rt2x00dev,
>                                                 const void *value,
>                                                 const u32 length)
>  {
> -       memcpy_toio(rt2x00dev->csr.base + offset, value, length);
> +#ifdef CONFIG_X86_64
> +       __inline_memcpy(rt2x00dev->csr.base + offset, value, length);
> +#else
> +       memcpy_toio(rt2x00dev->csr.base + offset, value, length);
> +#endif
>  }

The mail you refer to also talks about an alternative function which
can be used,
__iowrite32_copy() which wouldn't require the ifdef at all. Did you check that?
because having a single function is obviously much nicer then having extra
ifdefs in the code. ;)

Ivo



More information about the users mailing list