[rt2x00-users] [PATCH 4/7] rt2x00: Fix dead queue when skb allocation failed
Helmut Schaa
helmut.schaa at googlemail.com
Mon Oct 11 07:09:22 UTC 2010
Am Sonntag 10 Oktober 2010 schrieb Ivo van Doorn:
> When the RX skb allocation failed, we should recycle
> the previously allocated skbuffer. By calling return
> we would kill the RX queue completely since the
> entry would be invalidated.
>
> Signed-off-by: Ivo van Doorn <IvDoorn at gmail.com>
Good catch!
Acked-by: Helmut Schaa <helmut.schaa at googlemail.com>
> ---
> drivers/net/wireless/rt2x00/rt2x00dev.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index db25209..e5e8ba3 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -491,7 +491,7 @@ void rt2x00lib_rxdone(struct queue_entry *entry)
> */
> skb = rt2x00queue_alloc_rxskb(entry);
> if (!skb)
> - return;
> + goto submit_entry;
>
> /*
> * Unmap the skb.
>
More information about the users
mailing list