[rt2x00-users] [PATCH 5/7] rt2x00: Make queue_entry flags access atomic

[Helmut Schaa]

Am Sonntag 10 Oktober 2010 schrieb Ivo van Doorn:
> All access to the queue_entry->flags can be done concurrently,
> so all flags must use the atomic operators. On most locations
> this was already done, so just fix the last few non-atomic
> versions.
> 
> Signed-off-by: Ivo van Doorn <IvDoorn at gmail.com>

I haven't reviewed all code paths accessing the flags but it looks more safe
to use atomic access here.

Acked-by: Helmut Schaa <helmut.schaa at googlemail.com>

> ---
>  drivers/net/wireless/rt2x00/rt2x00usb.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/rt2x00usb.c b/drivers/net/wireless/rt2x00/rt2x00usb.c
> index 451d637..769c534 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00usb.c
> @@ -208,7 +208,7 @@ static void rt2x00usb_interrupt_txdone(struct urb *urb)
>  	struct queue_entry *entry = (struct queue_entry *)urb->context;
>  	struct rt2x00_dev *rt2x00dev = entry->queue->rt2x00dev;
>  
> -	if (!__test_and_clear_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags))
> +	if (!test_and_clear_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags))
>  		return;
>  
>  	/*
> @@ -220,7 +220,7 @@ static void rt2x00usb_interrupt_txdone(struct urb *urb)
>  	 * Check if the frame was correctly uploaded
>  	 */
>  	if (urb->status)
> -		__set_bit(ENTRY_DATA_IO_FAILED, &entry->flags);
> +		set_bit(ENTRY_DATA_IO_FAILED, &entry->flags);
>  
>  	/*
>  	 * Schedule the delayed work for reading the TX status
> @@ -407,7 +407,7 @@ static void rt2x00usb_interrupt_rxdone(struct urb *urb)
>  	struct queue_entry *entry = (struct queue_entry *)urb->context;
>  	struct rt2x00_dev *rt2x00dev = entry->queue->rt2x00dev;
>  
> -	if (!__test_and_clear_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags))
> +	if (!test_and_clear_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags))
>  		return;
>  
>  	/*
> @@ -421,7 +421,7 @@ static void rt2x00usb_interrupt_rxdone(struct urb *urb)
>  	 * a problem.
>  	 */
>  	if (urb->actual_length < entry->queue->desc_size || urb->status)
> -		__set_bit(ENTRY_DATA_IO_FAILED, &entry->flags);
> +		set_bit(ENTRY_DATA_IO_FAILED, &entry->flags);
>  
>  	/*
>  	 * Schedule the delayed work for reading the RX status
>