[rt2x00-users] [PATCH 1/2] rt2x00: Optimize register access in rt2800pci
Ivo Van Doorn
ivdoorn at gmail.com
Fri Apr 15 00:25:28 EST 2011
On Thu, Apr 14, 2011 at 4:19 PM, Helmut Schaa
<helmut.schaa at googlemail.com> wrote:
> On Thu, Apr 14, 2011 at 4:15 PM, Gertjan van Wingerde
> <gwingerde at gmail.com> wrote:
>> On Thu, Apr 14, 2011 at 12:01 PM, Helmut Schaa
>> <helmut.schaa at googlemail.com> wrote:
>>> All register reads/writes in rt2800pci were previously done with
>>> rt2800_register_read/rt2800_register_write. These however indirectly
>>> call rt2x00pci_register_read/rt2x00pci_register_write which adds an
>>> additional overhead of at least one call and several move instructions
>>> to each register access.
>>> Replacing the calls to rt2800_register_read/rt2800_register_write with
>>> direct calls to rt2x00pci_register_read/rt2x00pci_register_write gets
>>> rid of quite a number of instructions in the drivers hotpaths (IRQ
>>> handling and txdone handling).
>>> For consistency replace all references to rt2800_register_read/write
>>> with the rt2x00pci_register_read/write variants.
>>> Signed-off-by: Helmut Schaa <helmut.schaa at googlemail.com>
>> Exactly the same thing can be done inside rt2800usb (but then with the
>> rt2x00usb_register_read/write variants).
>> It's better to do everything in one go, so would you mind respinning the patch
>> with rt2800usb done as well?
> Correct. Thanks. I'll respin that one as well if you and Ivo agree with
> this approach.
Yeah, this patch is fine with me, I can also update rt2800usb in a
seperate patch if you prefer.
More information about the users