[rt2x00-users] Rework USB padding handling in rt2800usb

[Andreas Hartmann]

Hello Gertjan, hello Jakub!

Am Thu, 22 Dec 2011 20:32:01 +0100
schrieb Gertjan van Wingerde <gwingerde at gmail.com>:

> Hi Jakub,
> 
> On 12/21/11 12:31, Jakub Kiciński wrote:
> > Hi!
> >
> > As Ivo suggested USB padding should be handled by common code so I
> > modified rt2800usb not to add the padding on its own and slightly
> > changed rt2x00usb code to ensure padding is always zeroed.
> >
> > My previous posting of this patch was a little messy, sorry for that.
> > I post it again divided in two "logical changes" and with better
> > descriptions. Hopefully this time it will raise some comments.
> >
> 
> Andreas Hartmann (cc-ed on this message) reported that the driver breaks 
> for rt2800usb devices with these patches applied.
> I guess this breakage has to be investigated before we can apply this patch.
> 
> Andreas, can you elaborate what breaks with these patches applied?

I tested patch [1], but I missed [2]. Gertjan indicated me to apply
patch [2], too, which I hadn't applied for the first test.
I couldn't find any significant difference between the old handling 
and the new handling after applying _both_ patches.

I was interested because this driver behaves badly with rt3572 and
hoped, this patch would bring some improvement - unfortunately not.
I tested with a rt3572 based dongle using compat-wireless 3.1rc1 and
kernel 2.6.37.6 on a single core 32 bit machine.

Please excuse my inattentiveness! I should have seen, that both patches
should have been applied together for testing!


Kind regards,
Andreas

[1]
http://rt2x00.serialmonkey.com/pipermail/users_rt2x00.serialmonkey.com/2011-December/004345.html
[2]
http://rt2x00.serialmonkey.com/pipermail/users_rt2x00.serialmonkey.com/2011-December/004344.html