[rt2x00-users] [PATCH 4/7] rt2800usb: Let rt2x00usb handle USB padding
Andreas Hartmann
andihartmann at 01019freenet.de
Thu Dec 29 09:01:20 EST 2011
Gertjan van Wingerde schrieb:
> On 12/28/11 21:12, Ivo Van Doorn wrote:
>> On Wed, Dec 28, 2011 at 1:53 AM, Gertjan van Wingerde
>> <gwingerde at gmail.com> wrote:
>>> From: Jakub Kiciński <kubakici at wp.pl>
>>>
>>> Older USB drivers does not append end padding to skb but instead report
>>> it in size of data to be transmitted to HW. rt2800usb should follow that
>>> behaviour. Custom write_tx_data callback which was adding pad to skb
>>> is not be needed any more.
>>>
>>> Thanks to this patch frames handed back from rt2800usb to mac80211 will
>>> no longer contain end padding.
>>
>> What happened to the reports that after this (and the next) patch, the
>> non-2800 USB
>> drivers are failing?
>
> I have seen only 1 failure report (from Andreas Hartmann), which seemed
> to have been caused by not applying both patches. ISTR that Andreas did
> not see any regression when both patches were applied.
Yes, that's true. The behavior of a rt3572 dongle in my test with both
patches applied was the same as without these both patches.
Please note that the test I did was very short, because the rt2800usb
driver works really bad with this device anyway.
Kind regards,
Andreas Hartmann
More information about the users
mailing list