[rt2x00-users] [PATCHv2 3/6] rt2x00: Optimize TX descriptor memory layout

Helmut Schaa helmut.schaa at googlemail.com
Thu Feb 24 20:11:14 EST 2011


Am Mittwoch, 23. Februar 2011 schrieb Helmut Schaa:
> Some fields only need to be u8 and for ifs and txop we can use the
> already available enums which should translate to a u8.

Ivo, same here. If possible please drop "which should translate to a u8"
from the commit message. Or tell me to respin ;)

Thanks,
Helmut

> Acked-by: Gertjan van Wingerde <gwingerde at gmail.com>
> Signed-off-by: Helmut Schaa <helmut.schaa at googlemail.com>
> ---
>  drivers/net/wireless/rt2x00/rt2x00queue.h |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/rt2x00queue.h b/drivers/net/wireless/rt2x00/rt2x00queue.h
> index 3305520..3fa2406 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00queue.h
> +++ b/drivers/net/wireless/rt2x00/rt2x00queue.h
> @@ -315,17 +315,17 @@ struct txentry_desc {
>  
>  		struct {
>  			u16 mcs;
> -			u16 stbc;
> -			u16 ba_size;
> -			u16 mpdu_density;
> -			short txop;
> +			u8 stbc;
> +			u8 ba_size;
> +			u8 mpdu_density;
> +			enum txop txop;
>  		} ht;
>  	} u;
>  
>  	u16 rate_mode;
>  
>  	short retry_limit;
> -	short ifs;
> +	enum ifs ifs;
>  
>  	enum cipher cipher;
>  	u16 key_idx;
> 




More information about the users mailing list