[rt2x00-users] [PATCH 1/3] rt2x00: Minor optimization for devices with RTS/CTS offload

Gertjan van Wingerde gwingerde at gmail.com
Fri Feb 11 21:36:12 AEDT 2011


On Fri, Feb 11, 2011 at 9:53 AM, Helmut Schaa
<helmut.schaa at googlemail.com> wrote:
> Only devices that don't have RTS/CTS offload need to check for
> IEEE80211_TX_RC_USE_RTS_CTS and IEEE80211_TX_RC_USE_CTS_PROTECT.
>
> By swapping both conditions we keep the same number of needed conditionals
> for devices without RTS/CTS offload but save one conditional on devices
> with RTS/CTS offload.
>
> Signed-off-by: Helmut Schaa <helmut.schaa at googlemail.com>

Acked-by: Gertjan van Wingerde <gwingerde at gmail.com>

> ---
>  drivers/net/wireless/rt2x00/rt2x00mac.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00mac.c b/drivers/net/wireless/rt2x00/rt2x00mac.c
> index 658542d..eb93b03 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00mac.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00mac.c
> @@ -139,9 +139,9 @@ int rt2x00mac_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
>         * either RTS or CTS-to-self frame and handles everything
>         * inside the hardware.
>         */
> -       if ((tx_info->control.rates[0].flags & (IEEE80211_TX_RC_USE_RTS_CTS |
> -                                               IEEE80211_TX_RC_USE_CTS_PROTECT)) &&
> -           !rt2x00dev->ops->hw->set_rts_threshold) {
> +       if (!rt2x00dev->ops->hw->set_rts_threshold &&
> +           (tx_info->control.rates[0].flags & (IEEE80211_TX_RC_USE_RTS_CTS |
> +                                               IEEE80211_TX_RC_USE_CTS_PROTECT))) {
>                if (rt2x00queue_available(queue) <= 1)
>                        goto exit_fail;
>
> --
> 1.7.1
>
>
> _______________________________________________
> users mailing list
> users at rt2x00.serialmonkey.com
> http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
>



-- 
---
Gertjan




More information about the users mailing list