[rt2x00-users] [PATCH 5/5] rt2x00: Don't call ieee80211_get_tx_rate for MCS rates

Helmut Schaa helmut.schaa at googlemail.com
Wed Feb 23 23:27:26 AEDT 2011


Am Mittwoch, 23. Februar 2011 schrieb Gertjan van Wingerde:
> On Wed, Feb 23, 2011 at 12:45 PM, Helmut Schaa
> <helmut.schaa at googlemail.com> wrote:
> > ieee80211_get_tx_rate is not valid for HT rates. Hence, restructure the
> > TX desciptor creation to be aware of MCS rates. The generic TX desciptor
> > creation now cares about the rate_mode (CCK, OFDM, MCS, GF).
> >
> > As a result, ieee80211_get_tx_rate gets only called for legacy rates.
> >
> > Signed-off-by: Helmut Schaa <helmut.schaa at googlemail.com>
> 
> Acked-by: Gertjan van Wingerde <gwingerde at gmail.com>
> 
> With this, it may be better, as a follow-up patch, to remove
> rt2x00ht.c file altogether, and
> merge its contents with the common code. It is not a lot of code, so
> module sizes is not
> really an issue here, and the code becomes more readable by moving
> this code closer to
> where the functions are actually used.

Hmm, one reason why the HT code stays in its own file is that you can
compile rt2x00 without HT support. Should we build the HT descriptor stuff
always? Sounds reasonable to me.

Helmut




More information about the users mailing list