[rt2x00-users] [PATCH 03/12] rt2x00: Limit beacon updates in bss_info_changed to USB devices

Gertjan van Wingerde gwingerde at gmail.com
Sat Jan 15 08:45:49 EST 2011


On 01/14/11 10:41, Helmut Schaa wrote:
> Currently there are two places that trigger a beacon update on PCI
> devices. The bss_info_changed callback and the periodic update
> triggered by the TBTT or PRETBTT interrupt.
> 
> Since the next TBTT or PRETBTT interrupt will periodically fetch an
> updated beacon remove the update_beacon call in the bss_info_changed
> callback for PCI devices.
> 
> In the worst case it will take one beacon interval longer to fetch
> the new beacon then before. For devices that have a PRETBTT interrupt
> there should be no change at all.
> 
> Signed-off-by: Helmut Schaa <helmut.schaa at googlemail.com>

Acked-by: Gertjan van Wingerde <gwingerde at gmail.com>

> ---
>  drivers/net/wireless/rt2x00/rt2x00mac.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/rt2x00mac.c b/drivers/net/wireless/rt2x00/rt2x00mac.c
> index 89e6d75..b98a2ec 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00mac.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00mac.c
> @@ -617,9 +617,10 @@ void rt2x00mac_bss_info_changed(struct ieee80211_hw *hw,
>  				      bss_conf->bssid);
>  
>  	/*
> -	 * Update the beacon.
> +	 * Update the beacon. This is only required on USB devices. PCI
> +	 * devices fetch beacons periodically.
>  	 */
> -	if (changes & BSS_CHANGED_BEACON)
> +	if (changes & BSS_CHANGED_BEACON && rt2x00_is_usb(rt2x00dev))
>  		rt2x00queue_update_beacon(rt2x00dev, vif);
>  
>  	/*




More information about the users mailing list