[rt2x00-users] [PATCH 1/3] rt2x00: Fix rt2800 txpower setting to correct value

Ivo Van Doorn ivdoorn at gmail.com
Mon Jan 17 23:37:48 EST 2011


Hi,

>> >   */
>> >  #define EEPROM_TXPOWER_DELTA               0x0028
>> > -#define EEPROM_TXPOWER_DELTA_VALUE FIELD16(0x003f)
>> > -#define EEPROM_TXPOWER_DELTA_TYPE  FIELD16(0x0040)
>> > -#define EEPROM_TXPOWER_DELTA_TXPOWER       FIELD16(0x0080)
>> > +#define EEPROM_TXPOWER_DELTA_VALUE FIELD8(0x3f)
>> > +#define EEPROM_TXPOWER_DELTA_TYPE  FIELD8(0x40)
>> > +#define EEPROM_TXPOWER_DELTA_ENABLE        FIELD8(0x80)
>>
>> Is there a specific reason for reducing the width to 8 bit?
>
> The other bytes is for 5G band TX power delta, and I do not want to
> repeat the same definition for different band and can be used at
> rt2800_txpower_delta more easily.

I understand your point, but please keep the FIELD16 definitions,
that way rt2800.h will have an accurate register definitions. You could
perhaps add a helper macro to keep your code simple though. As long
as you add a nice comment about why you have this extra 8-bit definition.

Thanks,

Ivo



More information about the users mailing list