[rt2x00-users] [PATCH RFC] rt2800: disable powersaving as default
Ivo Van Doorn
ivdoorn at gmail.com
Tue Jan 25 03:08:04 EST 2011
On Tue, Jan 18, 2011 at 6:43 PM, Johannes Stezenbach <js at sig21.net> wrote:
> Powersaving is broken on rt2800usb (the hardware cannot do timed wakeup
> to receive beacons) and also on rt2800pci currently (auto-wakeup irq
> does no seem to work, for reasons so far unknown).
I just ran the stresstest with PS enabled and disabled (both cases with the
workqueue patch I just submitted), I also tested with the current 'experimental'
including your patches with PS disabled.
The result is:
master + PS: stresstest good, long association times (2-3 seconds on WPA2)
master - PS: stresstest good, short association times (1-2 seconds on WPA2)
experimental + PS: stresstest bad, long association times (2-3 seconds on WPA2)
experimental - PS: stresstest good, long assocation times (2-4 seconds on WPA2)
I also didn't find any problems with transfering data after assocating
with PS enabled or disabled.
So I am not really seeing a cause for disabling the powersaving at this moment.
If the beacon timeout is a big issue, doesn't that simply imply we provide the
wrong value to the TBCN_BEFORE_WAKUP register?
> Signed-off-by: Johannes Stezenbach <js at sig21.net>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index b7d91d5..b846fd9 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -3229,10 +3229,9 @@ int rt2800_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
> u16 eeprom;
> - * Disable powersaving as default on PCI devices.
> + * Disable powersaving as default.
> - if (rt2x00_is_pci(rt2x00dev) || rt2x00_is_soc(rt2x00dev))
> - rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
> + rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
> * Initialize all hw fields.
> users mailing list
> users at rt2x00.serialmonkey.com
More information about the users