[rt2x00-users] [PATCH] rt2x00: Fix STBC transmissions to STAs with Rx STBC > 1

[Gertjan van Wingerde]

On Thu, Mar 17, 2011 at 1:12 PM, Helmut Schaa
<helmut.schaa at googlemail.com> wrote:
> For STBC transmissions rt2x00 used the number of RxSTBC streams the
> destination STA indicates in its HT capabilities as STBC value in
> the TXWI.
>
> However, the legacy drivers and our own comment in rt2800.h suggest
> that the STBC field in the TXWI only allows a value of 0 or 1.
> The values 2 and 3 are reserved (probably for future devices).
>
> And indeed, STBC transmissions to STAs indicating more then 1
> RxSTBC stream fail when the STBC field is set to something >1.
>
> Fix this by only setting the STBC field to 1 when STBC should be
> used.
>
> Signed-off-by: Helmut Schaa <helmut.schaa at googlemail.com>

Acked-by: Gertjan van Wingerde <gwingerde at gmail.com>

> ---
>  drivers/net/wireless/rt2x00/rt2x00ht.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00ht.c b/drivers/net/wireless/rt2x00/rt2x00ht.c
> index ae1219d..e8c0c3e 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00ht.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00ht.c
> @@ -43,8 +43,11 @@ void rt2x00ht_create_tx_descriptor(struct queue_entry *entry,
>
>        txdesc->u.ht.ba_size = 7;       /* FIXME: What value is needed? */
>
> -       txdesc->u.ht.stbc =
> -           (tx_info->flags & IEEE80211_TX_CTL_STBC) >> IEEE80211_TX_CTL_STBC_SHIFT;
> +       /*
> +        * Only one STBC stream is supported for now.
> +        */
> +       if (tx_info->flags & IEEE80211_TX_CTL_STBC)
> +               txdesc->u.ht.stbc = 1;
>
>        /*
>         * If IEEE80211_TX_RC_MCS is set txrate->idx just contains the
> --
> 1.7.3.4
>
>
> _______________________________________________
> users mailing list
> users at rt2x00.serialmonkey.com
> http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
>



-- 
---
Gertjan