[rt2x00-users] [RFT] rt2x00: Tear down BA session on QoS frame failure

[Helmut Schaa]

Hi Andreas,

On Wed, Apr 11, 2012 at 7:59 AM, Andreas Hartmann
<andihartmann at 01019freenet.de> wrote:
> --- drivers/net/wireless/rt2x00/rt2x00dev.c.orig        2012-03-13 13:01:37.052100066 +0100
> +++ drivers/net/wireless/rt2x00/rt2x00dev.c     2012-04-11 05:42:31.514914691 +0200
> @@ -387,9 +387,6 @@
>                tx_info->flags |= IEEE80211_TX_STAT_AMPDU;
>                tx_info->status.ampdu_len = 1;
>                tx_info->status.ampdu_ack_len = success ? 1 : 0;
> -
> -               if (!success)
> -                       tx_info->flags |= IEEE80211_TX_STAT_AMPDU_NO_BACK;
>        }
>
>        if (rate_flags & IEEE80211_TX_RC_USE_RTS_CTS) {

This looks indeed like a suitable workaround for now but can cause a
stuck connection
with some intel clients as I've discovered before already.

Nevertheless, if you add a TODO comment "Need to tear down BA session
here" instead
of just removing the lines I'd ack that patch for upstream inclusion.

Mind to send it directly to John (Linville)?

Thanks a lot,
Helmut