[rt2x00-users] About rfkill racing issue.

Johannes Berg johannes at sipsolutions.net
Tue Apr 17 03:34:14 EST 2012


On 4/11/2012 11:15 PM, Matt Chen wrote:
> Hi list,
> It is found by notebook that rfkill doesn't work very right. I don't
> know where to post this discussion, so I choose here to start the
> talk.
> Basically we found the input handler in net/rfkill/input.c , because
> the nature of stateless key events, it can only toggle the saved
> state.  This screws up when started as blocked at
> boot, as already suspected.
> Now we thought Synchronizing to the
> hard block state looks as if working, but it's also dangerous because
> the operation is racy. The hard block check on ath9k driver is done
> in a poll basis, for example. Thus, the polling might happen just
> before the key event is handled, and it might happen after the key
> event.
> Another option would be to get synchronize the soft block state at the
> driver initialization time.  But, this doesn't work always because we
> never know whether ther rfkill key event is generated.  The rfkill key
> event depends on BIOS. Thus, if we set the soft block as same as the
> hard block at the init time (and set as blocked), the soft block will
> be never unblocked if some BIOS version doesn't emit a key event.
>
> So we would like to discuss with the all experts here for this issue.
> Do you have a good idea to fix the rfkill for the issue ?

How is hard rfkill related to input handling? It shouldn't be.

I don't understand what you're saying I think.

johannes



More information about the users mailing list