[rt2x00-users] [PATCH] Fix 'Error - MCU request failed' during initialization

[Jakub Kicinski]

Hi!

On Tue, 17 Jan 2012 12:13:49 +0100
Stanislaw Gruszka <sgruszka at redhat.com> wrote:

> Hi Jakub, 
> 
> On Mon, Jan 16, 2012 at 07:38:04PM +0100, Jakub Kicinski wrote:
> > I post my humble attempt to get rid of notorious Error - MCU request
> > failed ;)
> > 
> > I tried to fully mimic legacy driver, which should explain some obscure
> > moves like putting device to sleep and waking it up immediately.
> > 
> > Also during the work I earned some understanding of MCU requests and
> > found some info on arguments. Would you like me to share it or perhaps
> > add some documentation to header files?
> Sure.

Sure for sharing or for documentation? ;) 

> > The rt2800pci_set_state function got somehow lost during development
> > and I decided not to recreate it since it feels a little confusing to
> > me. Although note that behaviour for STATE_DEEP_SLEEP and STATE_STANDBY
> > will change. Previously transitions to those states were forwarded to
> > rt2800pci_set_state and ignored there. Now they will be treated the
> > same as STATE_SLEEP. In practice though, it shouldn't change behaviour
> > since mentioned states are not used in rt2800.
> > 
> > I have tested this on my only PCI device (rt: 2860, rf: 0001, rev:
> > 0102). Please post your comments and possibly give it more testing on
> > your devices.
> > 
> > ---
> > Bring MCU operations during device initialization to sync with legacy
> > driver.
> > 
> > This should fix following error:
> > phy0 -> rt2800pci_mcu_status: Error - MCU request failed, no response
> > from hardware
> I did not read your patch yet, but I think it is possible to solve this
> error by simpler patch (or maybe not, not sure), that I have already
> created. It also change behaviour of usb driver. Could you check if it
> helps with "MCU request failed" ?

Your patch doesn't really make any change for me, sorry.

As for simplicity, I probably made the mistake of kind of making two changes in one patch again, I'm still pretty much a noob. So please wait with reading of my patch, I will post a split version shortly.

  -- Kuba