[rt2x00-users] [RFC/RFT 8/8] rt2x00: Correctly set txmixer_gain in RT3572 channel switching.
Gertjan van Wingerde
gwingerde at gmail.com
Tue Jan 31 10:08:08 EST 2012
On 01/30/12 13:21, Stanislaw Gruszka wrote:
> On Sun, Jan 29, 2012 at 05:59:37PM +0100, Gertjan van Wingerde wrote:
>> Align with the v188.8.131.52 Ralink RT3572 driver.
>> Save the EEPROM txmixer_gain values inside the rt2800 driver data structure
>> and use it throughout the code.
>> Signed-off-by: Gertjan van Wingerde <gwingerde at gmail.com>
> Since we cache eeprom contents in the memory, we could use that instead
> of additional variables, but that code is fine to, it makes we match Ralink driver.
> Acked-by: Stanislaw Gruszka <sgruszka at redhat.com>
I know we could use the cached EEPROM contents, but that make fairly
unreadable code. I am actually considering to put more "parsed" EEPROM
fields in this structure, so that we don't have to parse the EEPROM over
and over again. This would only be done for EEPROM fields that are used
at run-time, not the ones that are only used at init time.
Thanks for the ACK anyway.
More information about the users