[rt2x00-users] [PATCH 3/3] rt2800pci: Fix 'Error - MCU request failed' during initialization

Stanislaw Gruszka sgruszka at redhat.com
Fri Jan 20 19:39:10 AEDT 2012


Hello

On Thu, Jan 19, 2012 at 03:26:21PM +0100, Jakub Kicinski wrote:
> > seems to be right, i.e. (if I underspend correctly) vendor driver do only
> > wakup (with 0x02 as last argument). But I can not comment, apparently 
> > I do not understand that stuff.
> 
> I think you may be referring to one of wake up function of legacy driver.
> Either RT28xxPciAsicRadioOn or RT28xxPciStaAsicForceWakeup. Those
> functions are to my understanding used to wake up form power saving and
> we will do same thing as they do in set_state(STATE_AWAKE), (well, a
> much simplified version of what they do actually ;)).
>
> set_state(STATE_RADIO_ON) OTOH is more of initialization call, as (if my
> grepping skills didn't go mad) it is only called from .start method. The
> sleep&wakeup dance can be found in NICInitAsicFromEEPROM, which in turn
> is called in legacy driver's .open method.

You have right. Ok so patch seems to be correct, it definitely fix issue
when we first do MCU wakeup and then MCU reboot. But I'm still not sure if
we need all 3 commands. Can we enable radio doing just 2 commands: reboot
(MCU_BOOT_SIGNAL) and wakeup, or maybe just reboot ?

Thanks
Stanislaw




More information about the users mailing list