[rt2x00-users] [PATCH] rt2x00 : fix rt3290 resuming failed.

Matt Chen machen at suse.com
Mon Jul 23 22:33:44 AEST 2012


Hi Stanislaw,

2012/7/23 Stanislaw Gruszka <sgruszka at redhat.com>:
> Hi
>
> On Mon, Jul 23, 2012 at 04:10:41PM +0800, Chen, Chien-Chia wrote:
>> This patch is going to fix the resuming failed from S3/S4
>> for rt3290 chip.
>>

>> +     if (rt2x00_rt(rt2x00dev, RT3290)) {
>Please add space after a comma.
It is done.

>> +             retval = rt2800_enable_wlan_rt3290(rt2x00dev);
>> +             if (retval)
>> +                     return -EBUSY;
>> +     }
>Since we enabling device here, it's probably not needed to do this on
>rt2800pci_probe_hw, or I'm wrong?
Oops, I missed it. :(


>> +                     if ((rt2x00_get_field32(reg, PLL_LD) == 1) &&
>> +                             (rt2x00_get_field32(reg, XTAL_RDY) == 1))
>> +                                     break;
>Use proper coding style here (see below). Seems you did not copy this
>function from rt2800pci.c, but take it form other source, so it could
>miss some other changes as well.
I've already made it as :
>+                       rt2800_register_read(rt2x00dev, CMB_CTRL, &reg);
>+                       if (rt2x00_get_field32(reg, PLL_LD) &&
>+                               rt2x00_get_field32(reg, XTAL_RDY))
>+                                      break;

>> +                     rt2800_register_write(rt2x00dev, 0x58, 0x018);
>> +                     udelay(REGISTER_BUSY_DELAY);
>> +                     rt2800_register_write(rt2x00dev, 0x58, 0x418);
>> +                     udelay(REGISTER_BUSY_DELAY);
>> +                     rt2800_register_write(rt2x00dev, 0x58, 0x618);
> We really like to know what those black magic numbers mean.
hmm...I've already talked with Ralink, they don't seem to be available
giving this meaning.
I will add to the author about this question.


> All my previous remarks was not fixed, you probably posted old patch.
>
> Stanislaw
>
> _______________________________________________
> users mailing list
> users at rt2x00.serialmonkey.com
> http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
>



-- 
Thank you.




More information about the users mailing list