[rt2x00-users] [PATCH] rt2x00 : fix rt3290 resuming failed.
sgruszka at redhat.com
Tue Jul 24 16:11:12 AEST 2012
On Tue, Jul 24, 2012 at 01:01:10PM +0800, Matt Chen wrote:
> Hi Stanislaw,
> 2012/7/23 Stanislaw Gruszka <sgruszka at redhat.com>:
> > On Mon, Jul 23, 2012 at 08:33:44PM +0800, Matt Chen wrote:
> >> >Use proper coding style here (see below). Seems you did not copy this
> >> >function from rt2800pci.c, but take it form other source, so it could
> >> >miss some other changes as well.
> >> I've already made it as :
> >> >+ rt2800_register_read(rt2x00dev, CMB_CTRL, ®);
> >> >+ if (rt2x00_get_field32(reg, PLL_LD) &&
> >> >+ rt2x00_get_field32(reg, XTAL_RDY))
> >> >+ break;
> > So is is still wrong.
> I am wondered the wrong is...?
More information about the users