[rt2x00-users] [PATCH 3.3] rt2x00: fix random stalls

Stanislaw Gruszka sgruszka at redhat.com
Tue Mar 6 22:53:22 EST 2012


On Tue, Mar 06, 2012 at 08:45:21AM +0100, Helmut Schaa wrote:
> > -       if (!rt2x00queue_threshold(entry->queue))
> > +       if (!rt2x00queue_threshold(entry->queue)) {
> > +               spin_lock_irq(&entry->queue->tx_lock);
> >                rt2x00queue_unpause_queue(entry->queue);
> > +               spin_unlock_irq(&entry->queue->tx_lock);
> 
> Why do we need to disable interrupts here? spin_lock_bh should
> be sufficient.

I'm not 100% sure, and I was to lazy to find out, and chose safer
version. I guess I need to find out now ...

Stanislaw



More information about the users mailing list