[rt2x00-users] [RFC/RFT 5/5] rt2x00: rt2800usb: limit tx queues length

Gertjan van Wingerde gwingerde at gmail.com
Sat Mar 10 08:21:54 EST 2012


On 03/07/12 20:07, Stanislaw Gruszka wrote:
> TX status fifo is limited to 16 elements. When we send more frames than
> that, we can easily loose status, what is not good for rate scaling
> algorithm.
> 
> On my testing the change does not degrade performance, actually make
> is slightly better. Additionally with the patch I can see much less
> various rt2x00 warnings in dmesg.
> 
> Signed-off-by: Stanislaw Gruszka <sgruszka at redhat.com>

Acked-by: Gertjan van Wingerde <gwingerde at gmail.com>

> ---
>  drivers/net/wireless/rt2x00/rt2800usb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
> index 1eb0cc3..4a1db29 100644
> --- a/drivers/net/wireless/rt2x00/rt2800usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2800usb.c
> @@ -879,7 +879,7 @@ static const struct data_queue_desc rt2800usb_queue_rx = {
>  };
>  
>  static const struct data_queue_desc rt2800usb_queue_tx = {
> -	.entry_num		= 64,
> +	.entry_num		= 16,
>  	.data_size		= AGGREGATION_SIZE,
>  	.desc_size		= TXINFO_DESC_SIZE + TXWI_DESC_SIZE,
>  	.priv_size		= sizeof(struct queue_entry_priv_usb),


-- 
---
Gertjan



More information about the users mailing list