[rt2x00-users] [PATCH 2/8] rt2x00: set pci mwi

Gabor Juhos juhosg at openwrt.org
Thu Nov 29 07:50:35 AEDT 2012


2012.11.28. 19:03 keltezéssel, Daniel Golle írta:
> Fixes https://dev.openwrt.org/ticket/6538

The fix was required for 'compat-wireless-2010-01-15' used by OpenWrt two years
ago. The fact that the patch is still used in OpenWrt does not mean that it
needs to be included in upstream.

> 
> diff --git a/drivers/net/wireless/rt2x00/rt2x00pci.c
> b/drivers/net/wireless/rt2x00/rt2x00pci.c index fa20add..0e0e8f2 100644 ---
> a/drivers/net/wireless/rt2x00/rt2x00pci.c +++
> b/drivers/net/wireless/rt2x00/rt2x00pci.c @@ -273,8 +273,10 @@ int
> rt2x00pci_probe(struct pci_dev *pci_dev, const struct rt2x00_ops *ops)
> 
> pci_set_master(pci_dev);
> 
> +#ifdef CONFIG_PCI_SET_MWI

Before the patch 'pci_set_mwi' is called unconditionally, so it is probably
needed on some systems. However the PCI_SET_MWI Kconfig symbol does not exists
in wireless-testing, so the following code would never be called.

> if (pci_set_mwi(pci_dev)) ERROR_PROBE("MWI not available.\n"); +#endif
> 
> if (dma_set_mask(&pci_dev->dev, DMA_BIT_MASK(32))) { ERROR_PROBE("PCI DMA
> not supported.\n");
> 





More information about the users mailing list