[rt2x00-users] [PATCH] rt2x00: usb: fix reset resume

John W. Linville linville at tuxdriver.com
Thu Oct 25 08:44:55 AEDT 2012


On Wed, Oct 24, 2012 at 08:35:26PM +0200, Stanislaw Gruszka wrote:
> On Tue, Oct 16, 2012 at 02:34:12PM +0200, Stanislaw Gruszka wrote:
> > Patch fixes warnings like below happened on resume:
> > 
> > WARNING: at net/mac80211/driver-ops.h:12 check_sdata_in_driver+0x32/0x34()
> > 
> > Problem is that in __ieee80211_susped() we remove sdata (i.e wlan0
> > interface) and then during resume we call usb_unbind_interface() ->
> > ieee80211_unregister_hw() with sdata removed.
> > 
> > Patch fixes problem by adding .reset_resume calback, hence we do not
> > unbind usb device on resume. This callback can be the same as normal
> > .resume callback, sice we do all needed initalization during interface
> > start, which is performed on resume [ ieee80211_resume() ->
> > ieee80211_reconfig() -> rt2x00mac_start() -> rt2x00lib_start ].
> > 
> > Resolves:
> > https://bugzilla.kernel.org/show_bug.cgi?id=48041
> > 
> > Reported-by: David Herrmann <dh.herrmann at googlemail.com>
> > Reported-and-tested-by: Stephen Boyd <bebarino at gmail.com>
> > Cc: stable at vger.kernel.org
> > Signed-off-by: Stanislaw Gruszka <sgruszka at redhat.com>
> 
> NACK for this patch, Randomly I'm able to reproduce strange crashes
> when suspending and transiting data, which seem to not happen without
> this patch. Until I'll figure this out, let's not apply the patch.

Of course, I just applied this today...any chance for a fixup?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville at tuxdriver.com			might be all we have.  Be ready.




More information about the users mailing list