[rt2x00-users] [PATCH] rt2x00: rt2x00pci: fix build error on Ralink RT3x5x SoCs

Gabor Juhos juhosg at openwrt.org
Tue Apr 2 19:10:48 AEDT 2013


2013.04.01. 21:24 keltezéssel, John W. Linville írta:
> I reckon that this is OK, since it is mostly just moving code around
> to satisfy build requirements.  But, it doesn't seem to apply to the
> wireless.git tree...?

Hm, you are right. The patch was based on the master branch of the
wireless-testing tree. It is my fault that I did not try it on wireless.git, sorry.

It fails to apply to the wireless.git tree because it depends on the following
change in wireless-testing.git:

commit 3a703ab5fba5b00292c1e7e964783c304f43fef7
Author: Tim Gardner <tim.gardner at canonical.com>
Date:   Mon Feb 18 12:56:28 2013 -0700

    rt2x00: rt2x00pci_regbusy_read() - only print register access failure once

    BugLink: http://bugs.launchpad.net/bugs/1128840

    It appears that when this register read fails it never recovers, so
    I think there is no need to repeat the same error message ad infinitum.

    Cc: Ivo van Doorn <IvDoorn at gmail.com>
    Cc: Gertjan van Wingerde <gwingerde at gmail.com>
    Cc: Helmut Schaa <helmut.schaa at googlemail.com>
    Cc: "John W. Linville" <linville at tuxdriver.com>
    Cc: linux-wireless at vger.kernel.org
    Cc: users at rt2x00.serialmonkey.com
    Cc: netdev at vger.kernel.org
    Cc: stable at vger.kernel.org
    Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
    Signed-off-by: John W. Linville <linville at tuxdriver.com>

Given the fact that this change is quite simple, it fixes a bug and it is marked
for stable, would it be possible to include that too into wireless.git?

Alternatively, I can rework my patch to be compatible with wireless.git, but
that will cause conflicts with the aforementioned change in wireless-testing.

-Gabor





More information about the users mailing list