[rt2x00-users] [PATCH 2/6] rt2x00: rt2400pci: use the rt2x00mmio_* routines

Gabor Juhos juhosg at openwrt.org
Sat Apr 6 02:26:37 AEDT 2013


2013.04.05. 15:32 keltezéssel, Stanislaw Gruszka írta:
> On Fri, Apr 05, 2013 at 08:27:01AM +0200, Gabor Juhos wrote:
>> Use the recently introduced rt2x00mmio_* routines
>> instead of the rt2x00pci_* variants.
>>
>> The patch contains no functional changes.
>>
>> Signed-off-by: Gabor Juhos <juhosg at openwrt.org>
>> ---
>>  drivers/net/wireless/rt2x00/rt2400pci.c |  309 ++++++++++++++++---------------
> 
> Why do you modify rt2400pci ?

Because the rt2x00pci_* functions provided by the rt2x00mmio module has been
renamed in the first patch and those are using the rt2x00mmio_ prefix now. The
rt2x00mmio.h header provides definitions for the old function names but those
definitions are removed by the last patch.

Here is a quote from 1/6:

"The renamed functions are used by several modules,
and updating the names in all of them would result
in a big patch. In order to keep the patch simple,
add compatibility defines for the old function
names. This allows to update the names in each
module separately. After each module is updated,
the defines can be removed."

Should I merge the whole series into a single patch instead?

-Gabor




More information about the users mailing list